search

nvpro-samples / vk_raytrace

Ray tracing glTF scene with Vulkan
Apache License 2.0
575 stars 35 forks source link

Minor tweaks towards supporting compiling the samples with `VS2015` #8

Closed missmah closed 3 years ago

missmah commented 3 years ago
  1. Support using std::exerpimental::filesystem on VS2015
  2. Include required Win32 headers
  3. Use OPENFILENAMEA instead of OPENFILENAME since the input is always of type char

Signed-off-by: Layla layla@insightfulvr.com

mklefrancois commented 3 years ago

Thanks for the suggestion, but as we are moving towards C++17 and higher, I don't want to add code supporting previous versions.

missmah commented 2 years ago

What's the harm in supporting multiple versions of the C++ language? I could see if it required doing something fundamentally different, but this is a couple of lines of compatibility boilerplate (which would improve adoption of this library by others)...