nvpro-samples / vk_raytracing_tutorial_KHR

Ray tracing examples and tutorials using VK_KHR_ray_tracing
Apache License 2.0
1.36k stars 143 forks source link

Build issue with VS2019 #2

Closed SirKnightTG closed 4 years ago

SirKnightTG commented 4 years ago

Using the vulkan driver, latest Vulkan-Headers and glslang, as the tutorial mentions, I am seeing the following errors in all projects:

1>------ Build started: Project: vk_ray_tracing__simple_KHR, Configuration: Debug x64 ------ 1>hello_vulkan.cpp 1>D:\Programming\Vulkan\shared_sources\nvvkpp/pipeline_vkpp.hpp(91,1): error C2440: 'return': cannot convert from 'vk::ResultValue' to 'vk::Pipeline' 1>D:\Programming\Vulkan\shared_sources\nvvkpp/pipeline_vkpp.hpp(91,1): message : No constructor could take the source type, or constructor overload resolution was ambiguous

NBickford-NV commented 4 years ago

I think this is probably the same issue as shared_sources #18 - at the moment, the version of vulkan.hpp in KhronosGroup/Vulkan-Headers changed the return type of createGraphicsPipeline, but doesn't have an implicit cast to the right type. However, the version of vulkan.hpp in KronosGroup/Vulkan-Hpp does - could you download and use the latest vulkan.hpp from https://github.com/KhronosGroup/Vulkan-Hpp/blob/master/vulkan/vulkan.hpp and see if that fixes it?

SirKnightTG commented 4 years ago

Yes, it seems this is the same issue. I used the vulkan.hpp you linked and it works. Thanks!

NBickford-NV commented 4 years ago

No problem, glad it worked!