search

nvpro-samples / vk_raytracing_tutorial_KHR

Ray tracing examples and tutorials using VK_KHR_ray_tracing
Apache License 2.0
1.34k stars 142 forks source link

ray_tracing_intersection - says add hitAttributeEXT to raytrace.rint but it's not there #20

Closed richardeakin closed 3 years ago

richardeakin commented 3 years ago

Hi,

I've been following these tutorials and first off wanted to say thanks so much! They are an excellent way to learn about this pretty sophisticated domain.

I wanted to point out something that has me scratching my head in the _ray_tracingintersection tutorial - it mentions the need for the following line in this section:

hitAttributeEXT vec3 HitAttribute;

However I don't see it in the intersection shader, hitAttributeEXT is only used within the closest hit shader. Is this an artifact of the previous version of the spec?

Thanks again for the great tutorials, Rich

mklefrancois commented 3 years ago

Hi @richardeakin, you are right, this is a left over from previous spec. I will remove it from the tutorial.

And thanks for the comments, really appreciated that it helped you.

mklefrancois commented 3 years ago

Fixed in https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/commit/9a174a8269abff96a8d0416e23e9556c1930f9c9