search

nvpro-samples / vk_raytracing_tutorial_KHR

Ray tracing examples and tutorials using VK_KHR_ray_tracing
Apache License 2.0
1.34k stars 142 forks source link

Update docs to #include "nvvk/raytraceKHR_vk.hpp" instead of "nvvk/raytrace_vk.hpp" #21

Closed sahouston closed 3 years ago

sahouston commented 3 years ago

Great tutorial, thanks for putting it together!

As I was going though the steps in https://nvpro-samples.github.io/vk_raytracing_tutorial_KHR/ I noticed it says to #include "nvvk/raytrace_vk.hpp", but this file doesn't exist anymore. This PR changes it to #include "nvvk/raytraceKHR_vk.hpp" as well as changing nvvk::RaytracingBuilder to nvvk::RaytracingBuilderKHR. Also RaytracingBuilderKHR::setup() takes a pointer to the allocator.

All these changes have already been made in the completed version of the code: https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/blob/9a174a8269abff96a8d0416e23e9556c1930f9c9/ray_tracing__simple/hello_vulkan.h#L37 https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/blob/9a174a8269abff96a8d0416e23e9556c1930f9c9/ray_tracing__simple/hello_vulkan.h#L148 https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/blob/9a174a8269abff96a8d0416e23e9556c1930f9c9/ray_tracing__simple/hello_vulkan.cpp#L661

mklefrancois commented 3 years ago

Thanks for pointing this out. The documentation will be fix in the next drop.