search

nvpro-samples / vk_raytracing_tutorial_KHR

Ray tracing examples and tutorials using VK_KHR_ray_tracing
Apache License 2.0
1.34k stars 142 forks source link

Incorrect vulkan object name was mentioned in the tutorial #33

Closed Erfan-Ahmadi closed 2 years ago

Erfan-Ahmadi commented 3 years ago

It should be VkPipelineShaderStageCreateInfo instead of VkPipelineStageCreateInfo

It also occured in 3 other places in the text

https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/blob/d66243800cf497a16dce555684e750917cbb7307/docs/vkrt_tutorial.md.html#L1070

mklefrancois commented 3 years ago

Thanks for pointing those issues. It will be fixed in the next update.

NBickford-NV commented 2 years ago

Looks like this is fixed now in 3e399a - line 1110 now says

At this point, the shader groups reference individual shaders by their index in the above `VkPipelineShaderStageCreateInfo`

Thanks again!