search

nvpro-samples / vk_raytracing_tutorial_KHR

Ray tracing examples and tutorials using VK_KHR_ray_tracing
Apache License 2.0
1.34k stars 142 forks source link

Invalid comment regarding the type of vertex data #34

Closed mateuszradomski closed 2 years ago

mateuszradomski commented 2 years ago

Hi,

I think it should be vec4 since we are defining a VK_FORMAT_R32G32B32A32_SFLOAT with 4 components. And because of that the comment is somewhat misleading.

https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/blob/d66243800cf497a16dce555684e750917cbb7307/docs/vkrt_tutorial.md.html#L299

mklefrancois commented 2 years ago

Thank you for reporting this. The vertex position is really a vec3, and therefore the vertexFormat should be VK_FORMAT_R32G32B32_SFLOAT. Fortunately the fourth component is ignored. I will fix this in this tutorial and the other ones as well.

NBickford-NV commented 2 years ago

Looks like this was fixed in d90ce7 - thanks again! https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/blame/master/docs/vkrt_tutorial.md.html#L296