search

nvpro-samples / vk_raytracing_tutorial_KHR

Ray tracing examples and tutorials using VK_KHR_ray_tracing
Apache License 2.0
1.34k stars 142 forks source link

gl_LaunchSizeEXT corresponds to the image size provided when calling traceRayEXT #60

Closed FuXiii closed 1 year ago

FuXiii commented 1 year ago

In 11.1 Ray generation (raytrace.rgen) :

gl_LaunchSizeEXT corresponds to the image size provided when calling traceRayEXT

In GLSL_EXT_ray_tracing :

The input variable gl_LaunchSizeEXT is available in the ray generation, intersection, any-hit, closest-hit, miss, and callable languages to specify the and and dimensions passed into a vkCmdTraceRaysKHR call.

Maybe we need change traceRayEXT to vkCmdTraceRaysKHR?

NBickford-NV commented 1 year ago

Yes, I believe this is a typo; I'll make an edit to fix it. Thanks!

NBickford-NV commented 1 year ago

Fixed in https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR/commit/9b84682b16733a72528b72d8dce818c7f373d22e; thanks again!