search

nvpro-samples / vk_video_samples

Vulkan video samples
Apache License 2.0
237 stars 40 forks source link

10-bit presentation looks wrong on radv #46

Open airlied opened 1 year ago

airlied commented 1 year ago

I'm seeing what looks like maybe 8-bit sampling from 10-bit data or something when testing HEVC 10-bit content.

Does it work okay on nvidia?

airlied commented 1 year ago

I wonder is this because I'm just running in an 24-bit X server

airlied commented 1 year ago

I just tried a depth 30 X session, but still seeing a red tint over the whole video.

airlied commented 1 year ago

okay this looks like radv doesn't offer ycbcr sampling on the format, I should probably investigate fixing that first.

zlatinski commented 3 months ago

Hi Dave,

Please also check the m_samplerYcbcrModelConversion and m_samplerYcbcrRange in VulkanFrame::DrawFrame(). Currently, the app has it fixed to BT709 NARROW range, but this should reflect the settings from the compressed content. Most of the 10/12-bit content uses BT2020 with full range. So, your colors can look off. I'll fix the app to handle this correctly, soon.