search

nvpro-samples / vk_video_samples

Vulkan video samples
Apache License 2.0
237 stars 40 forks source link

vk_video_encoder: handle "non-vcl" case with >= 1.3.250 #49

Closed remoe closed 1 year ago

remoe commented 1 year ago

I'm interested how one need to handle the "non-vcl" case with changed Vulkan API >= 1.3.250 here:

https://github.com/nvpro-samples/vk_video_samples/blob/b36f79c1756456ee5e8316c084a41f44e3c244b4/vk_video_encoder/NvEncodeApp.cpp#L685

and

https://github.com/nvpro-samples/vk_video_samples/blob/b36f79c1756456ee5e8316c084a41f44e3c244b4/vk_video_encoder/NvEncodeApp.cpp#L788

VkVideoEncodeH264EmitPictureParametersInfoEXT doesn't exists anymore:

https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VkVideoEncodeH264PictureInfoEXT :

Revision 10, 2023-03-06 (Daniel Rakos)

Removed VkVideoEncodeH264EmitPictureParametersInfoEXT

Does anyone have a hint for this?

Thanks.

remoe commented 1 year ago

Need to write SPS and PPS as a binary header data with NAL units. One can use a library like ffmpeg or x264 for it.