search

nvpro-samples / vk_video_samples

Vulkan video samples
Apache License 2.0
237 stars 40 forks source link

Fix validation warnings #57

Open charlie-ht opened 9 months ago

charlie-ht commented 9 months ago

There remain some less serious warnings after this series, but to fix some of the more difficult ones, changes in how the image handling and download happens were required.

Those commits start at "Use concurrent sharing when the transfer queue != decode queue". I'd like some review that this is an OK direction to take the sample app in before going much further.

/cc @zlatinski

zlatinski commented 3 months ago

Hi @charlie-ht, Can you please rebase your fixes against the ToT? Sorry, it took so long!

BattleAxeVR commented 3 months ago

I so look forward to using this so I can have 100% clean validation logs in my engine. It's also worrisome that some of the data wasn't even passed like the HEVC profile of the video in question during certain buffer creation, I had started to fix that but realized it needed some more serious refactoring to access that data from higher up the callstack.

charlie-ht commented 3 months ago

Hi @charlie-ht, Can you please rebase your fixes against the ToT? Sorry, it took so long!

Hi @zlatinski - unfortunately main has moved along in a way that makes a lot of this conflict. Perhaps best to close this one, and I'll try and find some time to pick over any validation errors that remain in the latest main branch.

https://github.com/nvpro-samples/vk_video_samples/pull/69 partly overlaps some of this work (the transfer queue exposure). Can you merge those fixes for AMD into the encode branch and the main branch?