search

nvpro-samples / vk_video_samples

Vulkan video samples
Apache License 2.0
237 stars 40 forks source link

Where is EncPicParams::refPicList initialised? #65

Closed friesofdoom closed 3 months ago

friesofdoom commented 4 months ago

https://github.com/nvpro-samples/vk_video_samples/blob/9840c6416353d6b9359407711544e85af6527cfb/vk_video_encoder/libs/VkVideoEncoder/VkVideoEncoder.h#L303

Should it get a call to GetReferenceFrameResourcesByIndex possibly?

It gets used here, but never initialized properly. https://github.com/nvpro-samples/vk_video_samples/blob/9840c6416353d6b9359407711544e85af6527cfb/vk_video_encoder/libs/VkVideoEncoder/VkVideoEncoder.cpp#L890

Is the code in Main in a stable state? It looks like it might not be - semi refactored?

Thanks!

zlatinski commented 4 months ago

@friesofdoom, the encoder portion of the sample in main is outdated and deprecated. Please use the https://github.com/nvpro-samples/vk_video_samples/tree/video-encode-h264-265-alpha WIP branch for your evaluation.

zlatinski commented 3 months ago

friesofdoom, please check the latest ToT code at main.