nvpro-samples / vk_video_samples

Vulkan video samples
Apache License 2.0
252 stars 41 forks source link

AV1 Decode: videoSessionParametersTemplate should be NULL #68

Closed lolzballs closed 6 months ago

lolzballs commented 7 months ago

If multiple sequence headers are present in the AV1 stream, the AV1 decoder will try to create a new VkVideoSessionParametersKHR with a videoSessionParametersTemplate set to the old one. VUID-VkVideoSessionParametersCreateInfoKHR-videoSession-09258 requires that VkVideoSessionParametersCreateInfoKHR::videoSessionParametersTemplate is NULL for AV1 decode parameters.

On AMD's beta driver, this causes the vkCreateVideoSessionParametersKHR to return an error.

zlatinski commented 7 months ago

Thank you, lolzballs! We'll fix that issue.

zlatinski commented 6 months ago

This is fixed now with 63c1ac2 at the ToT of https://github.com/nvpro-samples/vk_video_samples/tree/video-decode-av1-beta