nvs-vocabs / ArgoVocabs

A repository for the management of issues related to vocabularies managed by the Argo Data Management Team
7 stars 0 forks source link

How to record an Argo float ASD - Abrupt Salty Drift #38

Closed tcarval closed 10 months ago

tcarval commented 1 year ago

A series of floats are concerned with ASD : the Abrupt Salinity Drift of their salinity sensor. See https://argo.ucsd.edu/argo-salty-drift-salinity-data-issue-notice-2021/

To identify these floats, this proposal recommends to store the ASD information in :

Examples: ANOMALY = "ASD-AbruptSalinityDrift:NotConfirmed" This float has one anomaly : it is in the list of potential ASD, but the ASD is not confirmed

ANOMALY = "ASD-AbruptSalinityDrift:Confirmed,ending_cause_category:hardware,ending_cause:ballast" This floats has two anomalies : a confirmed ASD and an end of life due to hardware problem.

delphinedobler commented 1 year ago

I think the naming you propose fine. I was wondering whether we should add something indicating the cycle when it began, such as ASDAnomalyStartCycle:xx . The second item is the choice of colon to separate anomalies. If we ensure that namings of anomalies are constraint never to use colon, then it is fine. The same comment if we used semi-colon ";". I sometimes use the pipe sign "|", which has less probability to be used.

delphinedobler commented 1 year ago

Birgit comments: Do we really need the "notConfirmed" cases ? Can't it wait until the DMoperator solved the issue and just put the float on greylist in the meanwhile ?

tcarval commented 1 year ago

ASD-AbruptSalinityDrift:NotConfirmed" indicates that the sensor has a serial number in the list the potentially affected instruments. I think that this information is of interest. Maybe should we have one more term for the sensors that are in the list of potentially affected, that have been checked by PI and are actually not affected by ASD:

tcarval commented 1 year ago

ADMT-23 decision Record ASD in the ANOMALY variable of the metadata file, as a flaot ending cause The term to use is ASD:AbruptSaltyDrift

cgourcuf commented 1 year ago

I understood that we would not do this.

apswong commented 1 year ago

@tcarval. Including ASD as part of the ANOMALY vocabulary in the meta file is okay, but I suggest to not include ASD as part of the FLOAT_ENDING_CAUSE vocabulary, because it does not end the float's life - it merely ruins the salinity data.

tcarval commented 10 months ago

@apswong , hello Annie, I think that to complete this issue, a sentence could be added in the « Argo Quality Control Manual For CTD and Trajectory Data » https://doi.org/10.13155/33951, chapter §3.6.4

3.6.4. Examples of unadjustable salinity data – Abrupt Salty Drift (ASD) … When ASD is confirmed, record the information in the ANOMALY variable of the float metadata file with this keyword : ASD:AbruptSaltyDrift …

We may also add "from cycle #x" ... or not (to avoid consistency errors)

apswong commented 10 months ago

@tcarval, okay Thierry, I will add your suggestion to the next release of the Argo QC manual.

tcarval commented 10 months ago

Thank you Annie, so I close the ticket.