search

nvs-vocabs / ArgoVocabs

A repository for the management of issues related to vocabularies managed by the Argo Data Management Team
7 stars 0 forks source link

GDAC rejects files with SOLO_BGC #89

Closed ClaudiaAOML closed 2 months ago

ClaudiaAOML commented 3 months ago

SOLO_BGC as instrument type gets rejected by the GDACs. Because of that we have to send them as SOLO_II floats.

vpaba commented 2 months ago

Hi @ClaudiaAOML, thanks for opening this ticket, and thanks @tcarval for adding the term on the NVS.

It is just being reviewed before publishing, and we had a couple of questions: it may be useful to confirm whether it's designed by SIO and manufactured by MRV, or designed and manufactured by SIO as the NVS submission suggests? (if the former, and MRV is in fact the manufacturer of other SOLO floats, some other descriptions in R23 might need reviewing).

Also, and this is only minor, but would it be useful for the name be closer to its original name, if its original name is the following: https://www.mrvsys.com/products/s2-bgc - e.g. BGC_SOLO_II or SOLO_II_BGC? Just a suggestion - SOLO_BGC works just as well.

Thanks, Violetta

Edit: apologies, I've just seen https://github.com/nvs-vocabs/ArgoVocabs/issues/85. We'll commit SOLO_BGC on the NVS as requested!

tcarval commented 2 months ago

This ticket is a duplicate of https://github.com/nvs-vocabs/ArgoVocabs/issues/85

ClaudiaAOML commented 2 months ago

we are getting this from the format checker: PLATFORM_TYPE/PLATFORM_MAKER: Inconsistent: 'SOLO_BGC'/'MRV'

SOLO_BGC can have the manufacturer MRV or SIO. I wish I had know what would happen for this float (2903886_meta.nc) earlier ...

JohnEGilson commented 2 months ago

SOLO_BGC_MRV is available in R08. However, it is not listed in R23. This is the source of the issue. To be consistent with other SOLO family floats there should be a SOLO_BGC_MRV listed in R23.

SOLO_BGC_MRV : MRV : 886 (other?) : PLATFORM_TYPE_KEY?

tcarval commented 2 months ago

Hello Claudia and John, I added SOLO_BGC_MRV in R23 SOLO_BGC_MRV | 207 | 886 887 | MRV | MRV SOLO |

tcarval commented 2 months ago

Hello Claudia and John, I added SOLO_BGC_MRV in R23 SOLO_BGC_MRV | 207 | 886 887 | MRV | MRV SOLO |

The PLATFORM_TYPE_KEY is 207

I removed 886 and 887 WMO codr from SOLO_BGC entry

tcarval commented 2 months ago

The new release of the format checker is released: https://github.com/euroargodev/ArgoNetCDF/releases/tag/v2.8.11 Active on Coriolis GDAC, US-GDAC informed