search

nvs-vocabs / ArgoVocabs

A repository for the management of issues related to vocabularies managed by the Argo Data Management Team
7 stars 0 forks source link

WMO codes missing in NVS table - R08 (Eg: 872 and 869) #90

Open jnair-noaa opened 2 months ago

jnair-noaa commented 2 months ago

"WMO instrument type 872" is missing in table R08 (ARGO_WMO_INST_TYPE). Can this can be added? Eg floats: 3901260, 3901262.

vpaba commented 2 months ago

872 added to R08 (should be visible from tomorrow, 20th April)

jnair-noaa commented 2 months ago

Thanks @vpaba !

Also we noticed that there are more WMO codes missing in R08. Another one is "869". Requesting for a general review & update of R08 with respect to the WMO table.

tcarval commented 2 months ago

Here are "869" entries in the format checker

ref_table-23:NAVIS_EBR | 501 | 869 | SBE | SBE FLoat. serial >=590 | ref_table-8:869 | DOVA

gwemon commented 2 months ago

Dear All, could somebody provide the link to the WMO code table that is being referenced so that we have it in the ticket please? Thank you.

vpaba commented 2 months ago

@gwemon the Common Code table C-3 is linked in the R08 description on the NVS: https://library.wmo.int/doc_num.php?explnum_id=11283

However, this GitHub version of the table has also been referenced by @vturpin in another thread: https://github.com/wmo-im/CCT/commit/5f234050e0b4b08838af9b7ad187ec337f4706c1#diff-80cdc2d7308f541a438e53cecec1bd0143e158d7a675ab60655150804426e78c

I am not sure whether we should refer to the GitHub version for R08 updates, as new additions may appear there faster?

vpaba commented 2 months ago

@tcarval in looking to update R08 on the NVS with the latest additions to the C-3 table, I identified inconsistencies between the GDAC file checker (https://github.com/euroargodev/ArgoNetCDF/blob/main/file_checker_spec/ref_table-8) and the source C-3 table (linked in the comment above).

Please see inconsistencies below:

Code GDAC file checker name C-3 name
869 DOVA Reserved
870 NAMI HM2000
871 HM2000 COPEX

I was just wondering if this is intentional, or whether we should look into updating these codes in the GDAC file checker to maintain consistency with the C-3 table?

Another question I have is whether we should change 'SBE' to 'SBS' in all codes description that mention a Seabird conductivity sensor? Both R08 and C-3 have kept 'SBE' for the time being, but thought I'd ask.

gwemon commented 2 months ago

@gwemon the Common Code table C-3 is linked in the R08 description on the NVS: https://library.wmo.int/doc_num.php?explnum_id=11283

However, this GitHub version of the table has also been referenced by @vturpin in another thread: wmo-im/CCT@5f23405#diff-80cdc2d7308f541a438e53cecec1bd0143e158d7a675ab60655150804426e78c

I am not sure whether we should refer to the GitHub version for R08 updates, as new additions may appear there faster?

Thank you @vpaba . @vturpin is there a plan for C-3 to be added and managed via https://codes.wmo.int/?