nvs-vocabs / P01

Repository to manage issues related to the BODC P01 Vocabulary
5 stars 0 forks source link

NTR hazardous substances data in biota terms for EMODnet chemistry 5 [11 terms] #174

Closed roswri closed 2 years ago

roswri commented 2 years ago

Terms requested:

1-hydroxy phenanthrene will be 1-phenanthrol https://github.com/nvs-vocabs/S27/issues/18 as per CHEBII substance name

S25s to be created: https://github.com/nvs-vocabs/S25/issues/31

roy-lowry commented 2 years ago

@gwemon Don't know if it's an issue but I noticed perfluorooctanyl sulphonic acid rather than perfluorooctanyl sulfonic acid. Looking at S27 I see we use the US convention (sulf) in many cases with 'sulph' in the alternative label, but there are 26 occurrences of 'sulph' in the preferred label. @roswri Unless Gwen says otherwise I wouldn't let this observation block your generating these P01 terms.

gwemon commented 2 years ago

Thanks a lot @roy-lowry well spotted. Yes, you're right that we need to make sure we are consistent. We decided a while ago to align with IUPAC (https://www.nature.com/articles/nchem.301) and have the 'sulf' spelling in the preferred label (and the 'sulph' spellings in the alternative label field). I must have missed those 26! @roswri could you correct them when you get a chance please?

roswri commented 2 years ago

New terms created:

roswri commented 2 years ago

@gwemon, slight problem with updating the 'sulph's to 'sulf's... I think we have a set of duplicates: CS003522 - alpha-endosulphan+beta-endosulphan+endosulphan sulphate CS004455 - alpha-endosulfan+beta-endosulfan+endosulfan sulfate

Both are 'accepted'. Neither have been used in chem_model or cs_model.
CS003522 is in vocmap, but it's just linked to S01:S016 - chemical entity

I think we might need to deprecate the original term (CS003522) because if we deprecated the more recently created term and then updated the original the preflabel wouldn't be unique which is one of the constraints in the table. Would you agree with this?

Thanks, Roseanna

gwemon commented 2 years ago

Hi @roswri yes I agree.

roswri commented 2 years ago

Updated all sulph spellings to sulf in preflabel and vice versa for altlabels.

CS003522 deprecated. Updated CS004455 to include a definition and added 'sulph' spellings and CAS numbers to the altlabel. also added vacmap mapping between S27:CS004455 and S01:S016.

@gwemon - I don't have permission to insert into codedep, can I be granted permission to insert into codedep, or should I just get you/Dani to run that statement for me?