search

nvs / gem

Gem TD+: A Warcraft III Tower Defense
https://discord.gg/PxNNp77
26 stars 2 forks source link

Some `texttag` messages do not appear #364

Closed nvs closed 5 years ago

nvs commented 5 years ago

Not sure when this began, and I feel as though I have run into this issue at times for a good while, perhaps even in the old line. But it was significantly more rare before. However, situations such as the one fixed in f4bd47666b903826ee3353f05019310d7c553b12 most likely did not help.

Switching away from texttag has been considered in the past (e.g. #126). But, it is entirely possible that this issue is more prevalent in certain WC3 patches.

nvs commented 5 years ago

Given that texttag can be created locally for each player, it may be prudent to make them all locally. This should assist help prevent the built-in limit of 100 from being reached. Reproducing this issue, however, has proved rather difficult. I'm not ruling out bots or the latest patches playing a role; but, I'm hopeful that it involves the limit.

What is curious is that older versions of Gem (including the original line) did not present this issue often at all. If anything, it became more apparent once the Gem bot shifted from ENT to that which I host. That being said, a better solution in the long run may simply involve using a SFX, given that two slates could easily be made from the same Normal in the future.

nvs commented 5 years ago

For the most part, the 'Extra Chance!' message is simply informative. It is nice to be able to see it, but it is not absolutely required. The slate name's visibility, though, is paramount. We will go ahead with the idea in #126 and introduce a SFX when a slate can be created. We will deprecate the texttag, informing players that such functionality will eventually be removed.

As for the texttag issue itself, I have still not been able to reproduce it. If anything, after today, I'm more perplexed. The issue happened in every game I played in the same client session once I went online. I had played no other games of Gem online before that, although I had done a few single player testing games. But those were only to view changes in the changelog, and nothing more. There were no texttag created in those games.

nvs commented 5 years ago

I cannot remember seeing this as frequently since 1.30.2 has dropped. Will need to keep eyes open.

nvs commented 5 years ago

There have been no more reports of this issue. Closing it.