nvs / gem

Gem TD+: A Warcraft III Tower Defense
https://discord.gg/PxNNp77
26 stars 2 forks source link

1.6: Spell/Elder stopped casting spells #441

Closed nvs closed 5 years ago

nvs commented 5 years ago

It looks like I tried to change to using the damage event in a hurry, and neglected to notice that GetAttacker () is not in scope. So, in the end I have to do the work I tried to avoid anyway.

The fix for Spell Slate is pretty simple: don't make the mistakes I did when converting the code (which we will call trying to be lazy). The fix for Elder Slate is to revert back to using the on attack event. Due to using Sapphire damage (which is just spells in attack form), it is not really possible to accurately differentiate between Elder slate damage events that originate as either an attack or ability.

The 1.31 patch brings natives to discern additional information about damage events, which should make identifying the source of damage easier.