nvs / gem

Gem TD+: A Warcraft III Tower Defense
https://discord.gg/PxNNp77
26 stars 2 forks source link

Next round does not always start after all units killed #511

Closed nvs closed 5 years ago

nvs commented 5 years ago

There is no replay available, but the player had a Silver on round one. The board displayed 99.9%. But their next round did not begin. What is displayed on the board is purely cosmetic, to address rounding issues when a player leaked a monster with very low hit points. In reality, the progress was most likely 100%, as the player states they killed every monster.

nvs commented 5 years ago

I don't have the replay for the mentioned game. However, I do have a replay from a different related game; although, at the time, I thought that use of whosyourdaddy was to blame and thus would not present itself in typical gameplay.

Further investigation shows that a unit can be placed on the map and killed before all events handling units entering the map and/or regions fire. This seems to be exceedingly rare, but still possible. This may or may not be the cause of the issue in the game mentioned above. Various code in the map may need to be adjusted to safely address such situations.