search

nvs / gem

Gem TD+: A Warcraft III Tower Defense
https://discord.gg/PxNNp77
26 stars 2 forks source link

1.32: Game clock does not appear #514

Closed nvs closed 4 years ago

nvs commented 4 years ago

I was playing a game to test things out, and the clock disappeared. This occurs in 1.6.6+, but not in prior versions. This is most likely related to dd3f1a51fac96779e134a6090e7d0a3c225d5d93.

WC3ScrnShot_111319_200608_001

nvs commented 4 years ago

There seems to be an issue in 1.32 of comparing a null framehandle. In 1.31, it correctly compares to null in cases that matter to Gem. In 1.32, it fails these comparisons due to what I believe is a bug. It has been reported.

Regardless, this problem can be worked around easily by utilizing BlzFrameIsVisible (), instead of comparing to null. This will be fixed before Reforged comes out.

nvs commented 4 years ago

It should be noted that this was fixed in 1.32.0.13938, and the game clock from 1.6.7 appears and increments properly. However, the applied changes will remain. They simplify the code.