nvuillam / node-sarif-builder

JS/TS library to easily build valid SARIF output from your javascript based SAST tools
MIT License
11 stars 3 forks source link

SarifRuleBuilder Constructor Causes Loss of Valid SARIF Rule Options #56

Open AlexWilson-GIS opened 7 months ago

AlexWilson-GIS commented 7 months ago

https://github.com/nvuillam/node-sarif-builder/blob/2682b619b87130190c1511ef60b1d2310659e5f3/src/lib/sarif-rule-builder.ts#L10-L21

This is basically the same issue as my previous one (#55), only this time it applies to the rule, rather than the result. My suggested fixes are the same.

nvuillam commented 1 month ago

Is there still an issue ?