docs: fix required java version

nvuillam / npm-groovy-lint

Lint, format and auto-fix your Groovy / Jenkinsfile / Gradle files using command line

https://nvuillam.github.io/npm-groovy-lint/

MIT License

193 stars 61 forks source link

docs: fix required java version #341

Closed ariyonaty closed 6 months ago

ariyonaty commented 6 months ago

Fixes

Small change updating documentation specifying Java 17 as the primary version from the original range of versions 8 to 14. Pulled the latest tool today and was met with the following despite having Java 11 installed:

$ npm-groovy-lint
Java jre or jdk 17 is required
Installing Java jre 17 in <path>

Hopefully this helps provide clarification to others as well.

nvuillam commented 6 months ago

Thanks @ariyonaty :) Plz can you run npm run build ?

ariyonaty commented 6 months ago

Alrighty.. clearly I'm doing something wrong. I'll stop kicking off checks until I get a follow up. Unfortunately not familiar with node/npm, so this is a bit out of my element.

Tried:

Running npm run build standalone. Doesn't generate any diff.
Running npm install, then npm link, followed by npm run build. Still no diff (aside from package-lock.json)
In an attempt to mirror pipeline, npm run dev:pre-commit generates a diff in the form of updated lib/java/CodeNarcServer.jar, however latest build still shows failure.

Suggestions?

nvuillam commented 6 months ago

@stevenh can help us I think :)

stevenh commented 6 months ago

The change is in the generation of the server jar, have you followed the guide I created for this problem?

I would put money on you having a different node version, which uses a different version built in compression module.