nvzqz / divan

Fast and simple benchmarking for Rust projects
https://nikolaivazquez.com/blog/divan/
Apache License 2.0
849 stars 24 forks source link

remove misleading counter use from search examples #24

Closed thomcc closed 8 months ago

thomcc commented 8 months ago

Providing the haystack size here ends claiming that the throughput is going up even as the benchmark itself slows down. This is pretty misleading.

There's a sense in which it's technically true (if you count the items here are the items in the haystack), but given how dangerous misleading benchmarks are (even when technically true, which they often are), we shouldn't put it in our examples.