search

nwellnhof / perl-commonmark

Perl bindings for the CommonMark C library
https://metacpan.org/release/CommonMark
Other
5 stars 7 forks source link

Tests Crash on Windows #15

Closed theory closed 3 weeks ago

theory commented 11 months ago

Discovered as part of #12, and demonstrated in this 5.32 build on Windows, tests t/02_accessors.t and t/10_wrappers.t appear to crash after running a single test. I did a little debugging in this build, and it looks like both crash on the call to CommonMark->parse_file, which is defined in this XS code. Perhaps there's something there or in the cmark library's cmark_parse_file that isn't compatible with Windows?

nwellnhof commented 11 months ago

I don't have time to debug issues on Windows right now. Might be related to PerlIO.

theory commented 11 months ago

Yeah, I asked on Mastodon for thoughts, no takers. I'm sure someone who knows XS and Windows stuff can figure it out quickly. Alas, I know little about either myself. :-(

nwellnhof commented 11 months ago

FWIW, the Appveyor tests on Windows passed with 0.290000: https://ci.appveyor.com/project/nwellnhof/perl-commonmark. But for some reason, the new commits didn't trigger a test run.

theory commented 11 months ago

Huh, odd. I wonder if there's some difference in compiler toolchains at work here…

nwellnhof commented 11 months ago

The main difference is that the Appveyor tests are run under ActivePerl.

theory commented 11 months ago

Oh, interesting. The perl setup action uses plain old Perl, though there is an option to use Strawberry Perl. I wonder if it'd work there.

nwellnhof commented 3 weeks ago

Fixed with bf07b5e and b5369d9.