while we are on topic, theres another issue i was going to mention as well. i was following a discussion in discord about why someone said they wouldnt use your mod, and the coder person said "it's not async and the timeout is way too high. if discord fails to reply for whatever reason, the discord connector blocks the server, until all connected players time out."
and then another coder replied "he didn't put webrequest into async? i mean task* ...nvm, i see it now lol. well yeah true, i guess it was hard to write Task.Run"
idk bc im not a coder, but i have seen a lot of the big servers refuse to use your mod, and apparently this above is the reason. me personally i love the functionality of the mod and it works great for me, but i have good hardware, superb internet, and only maybe 25 players so i never run into this issue. but sometimes people DC when connected to my server so who knows. anyyway, maybe you can look into it and decide if its a problem. i hope this is well received, im only sharing what i read because id like to see your mod be the best it can be. thx for all the hard work you put in, its very much appreciated.
sry if maybe i shoulda put this in a separate thread...
while we are on topic, theres another issue i was going to mention as well. i was following a discussion in discord about why someone said they wouldnt use your mod, and the coder person said "it's not async and the timeout is way too high. if discord fails to reply for whatever reason, the discord connector blocks the server, until all connected players time out." and then another coder replied "he didn't put webrequest into async? i mean task* ...nvm, i see it now lol. well yeah true, i guess it was hard to write Task.Run"
idk bc im not a coder, but i have seen a lot of the big servers refuse to use your mod, and apparently this above is the reason. me personally i love the functionality of the mod and it works great for me, but i have good hardware, superb internet, and only maybe 25 players so i never run into this issue. but sometimes people DC when connected to my server so who knows. anyyway, maybe you can look into it and decide if its a problem. i hope this is well received, im only sharing what i read because id like to see your mod be the best it can be. thx for all the hard work you put in, its very much appreciated.
sry if maybe i shoulda put this in a separate thread...
Originally posted by @PaloAlo in https://github.com/nwesterhausen/valheim-discordconnector/issues/117#issuecomment-1207322680