nwesterhausen / valheim-discordconnector

A plugin to connect a Valheim server to a discord webhook.
https://discord-connector.valheim.games.nwest.one/
MIT License
27 stars 13 forks source link

On death, it announced me joining the world twice #20

Closed CruxCraft closed 3 years ago

CruxCraft commented 3 years ago

I just died, and it announced me joining the world when the loading screen first came up, and then again when it went away

nwesterhausen commented 3 years ago

Did you roll back to 0.7.0 or 0.6.0?

CruxCraft commented 3 years ago

Did you roll back to 0.7.0 or 0.6.0?

0.7.0 I guess technically not a rollback lol, as I went 0.6.0 --> 0.7.1 --> 0.7.0

I'd try to repeat it, except its an active server... I could probably start up a dedicated world for testing though, probably a good idea...

CruxCraft commented 3 years ago

Did you roll back to 0.7.0 or 0.6.0?

I rolled back to 0.6.0 now... & a player is on who dies a lot, so I should be able to tell you soon if it only started with 0.7.0

EDIT: The starting up message was fixed in 0.7.0 as I rolled back to 0.6.0 and it's now missing again

EDIT2: the double join message after a death existed in 0.6.0 as well, so I will go back to 0.7.0 and disable join messages for now =\

nwesterhausen commented 3 years ago

I just was able to test 0.7.0 and had it block a user that wasn't in the list from the shouts (and therefore pings) and then when I respawned from dying said I joined twice.

Going to get to the bottom of it

nwesterhausen commented 3 years ago

So I used the wrong comparison... was guaranteed to find non-matches and stop instead of matching and stopping

CruxCraft commented 3 years ago

Nice =] It's mostly working using two plugins, but I am very much looking forward to trying the new version this evening when I am tinkering around the server. I'll let you know if I notice anything out of the ordinary.

nwesterhausen commented 3 years ago

I think the only thing not fixed at the moment is two join messages when one should be a death message -- but I have to figure out a way to tell. Might have to record the player joining the first time then if they did, send a death message. I don't think they can disconnect without the server noticing. Going to try that now actually

CruxCraft commented 3 years ago

I think the only thing not fixed at the moment is two join messages when one should be a death message -- but I have to figure out a way to tell. Might have to record the player joining the first time then if they did, send a death message. I don't think they can disconnect without the server noticing. Going to try that now actually

If you ever need a 2nd person to jump in for some sort of testing, I'm available often for the time being and during random hours.

z.#8068

nwesterhausen commented 3 years ago

Death messages are added in 0.8.0, at least in my testing of my client to my server.

CruxCraft commented 3 years ago

Death messages are added in 0.8.0, at least in my testing of my client to my server.

I was wondering what in the world lol... went to download 0.7.1 from Nexus instead of here to Endorse it, and then saw 0.7.2 and 0.8.0

That sounds awesome because that is the only thing Notifier still had so I should be able to remove the it if this works =] Doing that now...

CruxCraft commented 3 years ago

It is now only a single join message instead of two...

is the join message intentional? As the player didnt actually leave the world... or it is something that has to be circumvented because it goes back to the loading screen in-between death/respawn

EDIT: I re-added notifier to just take over death events while that join message is still appearing, but then discovered that Player Death Notifications = false doesn't work; death messages still notify even when it's false

EDIT2: I thought I'd actually go the other way and that other handle joins and let yours do deaths (as the multiple death messages are really fun to have), but found another bug in the process If join notifications are false, then death messages wont show either.

nwesterhausen commented 3 years ago

This is fixed in 0.9.0 -- turns out I had removed the check for join and death messages being enabled

CruxCraft commented 3 years ago

I will check & test death messages specifically before noon (2-3pm)

CruxCraft commented 3 years ago

Appears fixed on the test server =] Thanks