nwfsc-fram / OceanTS

Oceanographic data processing in Typescript using NodeJS and Apache Arrow
0 stars 3 forks source link

Convert parsed raw results to engineering units #4

Open ghost opened 5 years ago

ghost commented 5 years ago

Convert the raw, decimal results over to engineering, decimal results.

ghost commented 5 years ago

Temperature and Pressure conversions are completed. Conductivity is completed, however I am off by a factor of 10, for both example CTD hex files as well as the conductivity calibration worksheet as a unit test.

Has the conductivity equation changed perhaps? I don't think so, but I've asked a colleague for an updated worksheet just to be safe. If that doesn't yield anything useful, I'll contact Seabird directly and see if they have any advice.

ghost commented 5 years ago

The updated conductivity calibration worksheet shows the same equations. I have emailed Seabird directly asking for confirmation of the equations and about the factor of 10 discrepancy.

ghost commented 5 years ago

Salinity equation is completed and confirms correct results against an actual data processed using the Seabird Data Processing software. Working on oxygen data calculations currently for both the SBE43 and OPTODE Aanderaa sensors.

ghost commented 5 years ago

In talking with the Seabird tech support staff, it turns out that there is a division by 10 in the conductivity equation that may be erroneous, caused by their PDF generation software. Removing that solves the conductivity issue. I am still waiting to hear back that this is indeed the case.

Also, the oxygen equation and unit testing is all in place now, however my unit tests are not passing, so investigating. This is only for the SBE43 oxygen, I still have to code up the OPTODE Aanderaa oxygen sensor yet.

ghost commented 5 years ago

The OPTODE Aanderaa oxygen processing is now in place as well.

ghost commented 5 years ago

SBE43 Oxygen data unit testing is not correct, investigating ...