search

nwfsc-fram / boatnet

At-Sea Field Data Collection Software Components for Scientific Surveys and Observers
8 stars 5 forks source link

add "provider" to logbook json example #2365

Closed neilriley-NOAA closed 3 years ago

neilriley-NOAA commented 3 years ago

@sethgerou-noaa the "provider" field is missing from the logbook json example in the app.

image

neilriley-NOAA commented 3 years ago

@sethgerou-noaa. this change looks fine. correct me if I am wrong but we would not be able to identify the person (3rd party staff person) that submitted the data? Wondering if we need to add review name?

sethgerou-noaa commented 3 years ago

We expect reviewerName in submissions - we also store the boatnet username of the boatnet account that submitted the data to the api. https://github.com/nwfsc-fram/boatnet-module/blob/master/bn-models/src/models/trips-api/catches.ts

I'd think reviewerName would be the more reliable means of determining who submitted the data as a 3rd party provider could elect to use a single boatnet account to link all their software to the tripsApi.

This is another case where it would be useful to have a listing of required logbook fields and required review fields.

neilriley-NOAA commented 3 years ago

Agreed. I am working on a listing of required logbook fields and required review fields today.