search

nwfsc-fram / boatnet

At-Sea Field Data Collection Software Components for Scientific Surveys and Observers
8 stars 5 forks source link

EM comparison page not working #2390

Closed neilriley-NOAA closed 2 years ago

neilriley-NOAA commented 3 years ago

EM comparison page not working. Example tripNum = 100308

sethgerou-noaa commented 2 years ago

should be working now.

When we switched to require wcgop code be a number the wcgop-code-to-pacfin-code cross walk and the ifq-grouping lookup broke - made sure wcgop code is a number everywhere and the queries expect a number.

submitting new review data 'should' correct the logbook data for a given trip, but I haven't confirmed this yet.

neilriley-NOAA commented 2 years ago

@sethgerou-noaa the comparison screen is still not working in Prod. example 100319. Neither logbook or Review data is displayed.

neilriley-NOAA commented 2 years ago

looks like the comparison screen is working again. Can you detail how the logbook review difference, is being calculated in trip 100308? I am unable to replicate the results displayed for the trip. Also, it should display the difference for each species grouping.

image

sethgerou-noaa commented 2 years ago

hmm, weird. You would expect the Diff Review Logbook column to have 500% for Pacific Whiting, correct? What would you want to see in that column when the grouping isn't present in the logbook or review data?

neilriley-NOAA commented 2 years ago

Duh. The original is right. I am forgetting my basic algebra.

|V1−V2|[(V1+V2)2]×100=% difference

Initiall am not sure how to display the difference when there is nothing is reported. The percent difference requires a value greater than zero. but we need to make these comparisons when applying the pass fail rules. I am not sure if a zero is better than a null. may be worth talking this one through.

neilriley-NOAA commented 2 years ago

This working now.