search

nwfsc-fram / boatnet

At-Sea Field Data Collection Software Components for Scientific Surveys and Observers
8 stars 5 forks source link

EM calculation bug #2395

Open neilriley-NOAA opened 2 years ago

neilriley-NOAA commented 2 years ago

@sethgerou-noaa there is a bug in the calculation code

image

Example trip is 100322 in Dev: I submitted a discard for a single sablefish length (50 cm) which returned a weight of 1 lb. The weight should be 2.64 lbs. I think the error is with the β. appears the Beta value is being multiplied instead of being raised to the power.

Sablefish
α = 0.000003927 β = 3.430072

image

neilriley-NOAA commented 2 years ago

submitted review data for trip 100322 in dev. the review data is not displaying on the comparison or the em review page.

neilriley-NOAA commented 2 years ago

@sethgerou-noaa for trip 100325 I calculated a different value than what is displayed in the EM results table for sablefish. Below is the json of the catch record. I calculate a 2.64 lbs for a single fish at 50 cm. The EM results page is displaying 4 lbs. Not sure where the bug is?

    {
      "disposition": "Discarded",
      "speciesCode": "SABL",
      "speciesLength": 50,
      "speciesCount": 1,
      "calcWeightType": "Estimated Weight",
      "comments": "Count greater than 1 for a length"
melinashak-noaa commented 2 years ago

This was caused by the missing weight expansion pulling all catch data, even that in the revision history. So fixed it to just pull just the current catch and now it's calculating correctly. Getting 2.64 now.

Just a note, @neilriley-NOAA the discard mortality rate rule is also being applied to trip 100325 since catch is sablefish and gear used is pot. So speciesWeight = 2.64 * .2 = .528 since 20% mortality is taken . When I change gear to longline (snap) getting 2.64 though.