search

nwfsc-fram / boatnet

At-Sea Field Data Collection Software Components for Scientific Surveys and Observers
8 stars 5 forks source link

Edit dates not available after the trip return date has passed #872

Closed neilriley-NOAA closed 5 years ago

neilriley-NOAA commented 5 years ago

@sethgerou-noaa

I created 2 trips (see screen shot for dates).

image

I then try to edit the first trip (9/20-9/22) to change the return date and 9/23 -9/24 are not available. I realize the proper thing to do it close the trip and edit the dates in the close trip window. I am wondering if users will get hung in the edit window wondering how to change the dates? I am just wondering if we need some sort of msg here?

@scottleach-NOAA @johnlafargue-noaa thoughts?

image

sethgerou-noaa commented 5 years ago

yeah, not sure how to handle this - I'm trying to prohibit entering start and stop dates that are in the past (why you can't select the 23rd or 24th), but when a range of dates must be selected when a trip has already started, it may be necessary to select a start date in the past. Haven't found a way to allow a start date in the past, but not an end date in the past. Hope that makes sense.

Your suggestion could help - once a trip has started the days can't be modified - if the captain tries to edit the dates, they get a popup explaining the dates can't be modified - rather they should be entered correctly when the trip is closed. This does not account for the case where the first trip needs to be shortened to accommodate a new (earlier) start date for the second trip.

On Wed, Sep 25, 2019 at 9:19 AM Neil Riley notifications@github.com wrote:

@sethgerou-noaa https://github.com/sethgerou-noaa

I created 2 trips (see screen shot for dates).

[image: image] https://user-images.githubusercontent.com/31421964/65614708-f1574080-df6c-11e9-8b64-086c729e24e0.png

I then try to edit the first trip (9/20-9/22) to change the return date and 9/23 -9/24 are not available. I realize the proper thing to do it close the trip and edit the dates in the close trip window. I am wondering if users will get hung in the edit window wondering how to change the dates? I am just wondering if we need some sort of msg here?

@scottleach-NOAA https://github.com/scottleach-NOAA @johnlafargue-noaa https://github.com/johnlafargue-noaa thoughts?

[image: image] https://user-images.githubusercontent.com/31421964/65619444-0041f100-df75-11e9-900c-11275bf2efe4.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nwfsc-fram/boatnet/issues/872?email_source=notifications&email_token=AJC7LYO2JH6A3GI7JWCQ55TQLOFSDA5CNFSM4I2PCMZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HNU2UTQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AJC7LYLKBRN7NRBVHLYNUHLQLOFSDANCNFSM4I2PCMZA .

--

Seth Gerou

Web Developer - NOAA Affiliate

Earth Resources Technology, Inc. (ERT, Inc)

Northwest Fisheries Science Center

2725 Montlake Boulevard E

Seattle, WA 98112

M: 206-349-6449

seth.gerou@noaa.gov

neilriley-NOAA commented 5 years ago

I don't have a good answer either. I think we should talk this one through with the group.

ericbrasseur-NOAA commented 5 years ago

But Neil, a real god would...