search

nwg-piotr / autotiling

Script for sway and i3 to automatically switch the horizontal / vertical window split orientation
GNU General Public License v3.0
930 stars 30 forks source link

Fixed manually switching between layouts not working #32

Closed ErikReider closed 2 years ago

ErikReider commented 3 years ago

Fixes this layout change issue:

https://user-images.githubusercontent.com/35975961/138968708-9f25fc71-83d2-4188-a794-3562bef9eb28.mp4

Also fixes this issue where the indicator (the light blue indicator) doesn't update when closing a non-disowned application from the terminal. Look at the right terminals indicator

https://user-images.githubusercontent.com/35975961/138969594-af05399a-b05f-4a14-b8c1-602c7ace9b03.mp4

Removing the BINDING event fixed the indicator updating issue while using the WINDOW event instead of WINDOW_Focus updates more often.

nwg-piotr commented 3 years ago

The BINDING event has already been added, removed and added back again. Every time to fix someone's issue.

ErikReider commented 3 years ago

Using MODE instead of binding should still call the handler after exiting the resize mode and doesn't interfere with all of the other keybindings

nwg-piotr commented 3 years ago

Sorry, I'm on dwl now instead of sway, so can't take a closer look. Will give it a try in the morning.

ErikReider commented 3 years ago

Great. You just made me realize that it's 1 AM...

Unrelated question: What are your opinions about dwl?

nwg-piotr commented 3 years ago

What are your opinions about dwl?

Have you ever seen laylaOS? mrneilypops built it on dwm, and it proves that dwm may look well. So I thought to check if my stuff could run on dwl. I'm working on the dwl module to nwg-panel at the moment.

Even though I've never liked the idea of tags, I need an alternative, as sway above v1.5 suffers from many issues on my hybrid AMD laptop, and the developers don't care much about it.

dwl is as much a DIY kit as dwm, but works not bad for me.

ErikReider commented 3 years ago

Never heard of it before... Looks neat! I'll have to check it out and maybe port swaysettings (shameless plug) to it :)

nwg-piotr commented 3 years ago

Hope you mean dwl. Layla bases on dwm.

ErikReider commented 3 years ago

Oh yeah, that's what I meant 😅

travankor commented 3 years ago

Even though I've never liked the idea of tags, I need an alternative, as sway above v1.5 suffers from many issues on my hybrid AMD laptop, and the developers don't care much about it.

How about swayfire? I'm looking for the best Wayland tiler as well (not sway since it has too many bugs and regressions every new release). Or I might try river again, too.

ErikReider commented 3 years ago

@travankor Wayfire has been a peculiar experience for me. It looks great with all of that good looking eye-candy but it lacks some of the better features and stability of Sway. I'd probably try it again if they incorporated a sway-ipc like feature :)

nwg-piotr commented 3 years ago

I'd probably try it again if they incorporated a sway-ipc like feature

Exactly my words. But the developers seemed uninterested in such a feature. As soon as swayfire does the job, I'll definitely need to take a look.

nwg-piotr commented 3 years ago

Or I might try river again, too.

River is great, but drives me mad with the necessity of switching outputs by hand. I'm on a triple-headed setup. Waiting for a response to this.