search

nwg-piotr / nwg-displays

Output management utility for sway and Hyprland.
MIT License
334 stars 22 forks source link

[Feature requset] River support #30

Open Sunderland93 opened 10 months ago

Sunderland93 commented 10 months ago

https://github.com/riverwm/river

nwg-piotr commented 10 months ago

Basically nwg-shell and its components are for sway and Hyprland. By adding support for other window managers (such as DWL tags in nwg-panel), I know that I won't use it myself, so the option may be poorly tested and not further developed. At the moment the answer is no. Perhaps on long winter evenings.

cvoges12 commented 2 days ago

@nwg-piotr I would be happy to maintain and test for riverwm support.

Please re-open so I can contribute.

nwg-piotr commented 2 days ago

@cvoges12 - sure, go ahead.

cvoges12 commented 2 days ago

I'm going to notate all the places where sway / hyprland dependent code is taking place and start adding the riverwm equivalents.

So far I've found:

I'll keep listing as I go through. I've noticed that there are some generically named functions and such that are only being used for sway. I'll refactor and rename these before I continue to ease the process. I'll send a PR regarding this change separately since it should probably be done anyways regardless if the changes for this issue get merged or not.

nwg-piotr commented 2 days ago

Keep in mind that I'm only going to test your changes on sway and Hyprland. River-related stuff remains your responsibility.

cvoges12 commented 2 days ago

Yep, I'm fully aware. Right now I'm just trying to get a sense of the project and where all the compositor specific code is.