search

nwg-piotr / nwg-displays

Output management utility for sway and Hyprland.
MIT License
334 stars 22 forks source link

Popup + countdown to prevent incorrect configuration #31

Closed hakan-demirli closed 9 months ago

hakan-demirli commented 9 months ago

I accidentally changed my refresh rate to 59 instead of 60. My monitor instantly turned dark and I had to manually fix it via tty login.

Other display tools such as gnome, kde and Windows Display Settings offer a countdown mechanism that resets the display settings after 20 seconds if the user do not press apply again. Can you add such a feature to nwg-displays?

nwg-piotr commented 9 months ago

Yes, it could be done. I'll try in the nearest future.

nwg-piotr commented 9 months ago

This is not as easy as one could expect. I'm testing on Hyprland, and some settings (improper refresh rate, improper screen dimensions) just crash the compositor, together with my program, of course. No chance to restore anything. So this will be a half-way solution.

hakan-demirli commented 9 months ago

I have found a related problem https://github.com/hyprwm/Hyprland/issues/3083 they mention it being a wlroots bug.

In one of the issues mentioned, they say Hyprland using a slightly old wlroots version. I think the crash problem will be gone in couple of months after they update their dependencies. If not I will open an another issue over there tagging this one.

nwg-piotr commented 9 months ago

Very well. I need to add translations for the new window, then it should be ready.

nwg-piotr commented 9 months ago

It seems not to crash on Hyprland 0.30.0.

nwg-piotr commented 9 months ago

Done. :rofl:

image