search

nwg-piotr / nwg-dock

GTK3-based dock for sway
MIT License
173 stars 9 forks source link

Compile error with Debian #5

Closed rbutoi closed 3 years ago

rbutoi commented 3 years ago

With Debian testing, getting the following build error (can build fine on Arch Linux):

$ make get
go get github.com/gotk3/gotk3@289cfb6dbf32de11dd2a392e86de4a144ac6be48
go get github.com/gotk3/gotk3/gdk
go: found github.com/gotk3/gotk3/gdk in github.com/gotk3/gotk3
v0.5.3-0.20210223154815-289cfb6dbf32
go get github.com/gotk3/gotk3/glib
go: found github.com/gotk3/gotk3/glib in github.com/gotk3/gotk3
v0.5.3-0.20210223154815-289cfb6dbf32
go get github.com/dlasky/gotk3-layershell/layershell
go: found github.com/dlasky/gotk3-layershell/layershell in github.com/dlasky/gotk3-layershell
v0.0.0-20210331230524-5cca0b819261
# github.com/dlasky/gotk3-layershell/layershell
../../.go/pkg/mod/github.com/dlasky/gotk3-layershell@v0.0.0-20210331230524-5cca0b819261/layershell/layer.go:93:35:
could not determine kind of name for C.GtkLayerShellKeyboardMode
../../.go/pkg/mod/github.com/dlasky/gotk3-layershell@v0.0.0-20210331230524-5cca0b819261/layershell/layer.go:93:2:
could not determine kind of name for C.gtk_layer_set_keyboard_mode
make: *** [Makefile:5: get] Error 2

libgtk-layer-shell-dev 0.5.2-1, go1.15.9

Worth asking @dlasky too

nwg-piotr commented 3 years ago

@rbutoi BTW I also remember having this issue on Debian (Buster): https://github.com/gotk3/gotk3/issues/693 Hope it doesn't happen on Testing (whatever it means).

dlasky commented 3 years ago

It looks like that method was introduced on .6.0 of gtk layer shell library:

https://github.com/wmww/gtk-layer-shell/blob/master/include/gtk-layer-shell.h#L343

we could try adding some conditional feature detection so it builds but I'm not sure how this would affect your app functionally @nwg-piotr

nwg-piotr commented 3 years ago

I gave up on keyboard in the dock, so it's not a problem. However, it would be better to keep up with the gtk-layer-shell development. @rbutoi - isn't it possible to have a recent version on Debian?

dlasky commented 3 years ago

It's pretty easy to build from source which is what I was doing before it landed in aur.

Lmk if you want me to write bindings for the version detection

nwg-piotr commented 3 years ago

Let's wait for @rbutoi 's response.

rbutoi commented 3 years ago

Ah, thanks for the pointers, both! It it, indeed, very easy to build gtk-layer-shell, and it let me compile nwg-dock here.

dlasky commented 3 years ago

Glad to help (and that it worked!) cheers

nwg-piotr commented 3 years ago

Many thanks, Dan!