search

nwg-piotr / nwg-drawer

Application drawer for wlroots-based Wayland compositors
MIT License
250 stars 27 forks source link

Allow specifying settings in a config file #37

Closed nightly-brew closed 2 years ago

nightly-brew commented 2 years ago

Hi, would it be possible to specify launch settings in a config file as well? I think it would be of help in standardizing systemd user units and xdg autostart desktop files.

Ideally, nwg-drawer could try to read something like "$XDG_CONFIG_DIR/nwg-drawer/settings" at startup. For those use-cases where "-r" is specified, the launched instance could first try to trigger the background one, if it exists (kind of like it already does). If no background instance is running instead, it just starts as that.

Of course, cli arguments should still have precedence over the config file, to allow overriding the default behaviour when needed.

nwg-piotr commented 2 years ago

Well, I wanted to keep it simple, so planned on config files for nwg-panel only. It's kinda enough of json to deal with. For now I'd say "no", but it could be considered in future development. At the moment I'm working on integration of all the nwg-shell stuff with a common config GUI, and wouldn't like to focus on other things. Also: all the shell components have GUI if they have a config file. I don't think I want another GUI.

nightly-brew commented 2 years ago

Got it, thanks anyway!

nightly-brew commented 2 years ago

@nwg-piotr Would it be better to add a "wontfix" label?

nwg-piotr commented 2 years ago

This doesn't look kind. :)

nightly-brew commented 2 years ago

ok, thanks again :)

nwg-piotr commented 2 years ago

You may like the new nwg-shell-config app. It includes some drawer settings. Coming soon in ArchLabs Linux.

2022-01-03-124540_screenshot

nightly-brew commented 2 years ago

That I certainly do! As a matter of fact, I already find the ability to configure nwg-panel both through file and ui a wonderful feature. Having it more integrated with your other programs is great!

On a side note, I'm going to bother you later on nwg-panel with an issue I encountered with sway workspaces, still, thanks man for your work :)

nwg-piotr commented 2 years ago

an issue I encountered with sway workspaces

Probably the same which I discovered last night while testing (I don't use this module in real life) and wanted to fix at the office. Unfortunately it doesn't appear on my testing laptop, and needs to wait until I'm back home. Feel free to submit. It may make it easier to fix.