nwg-piotr / nwg-panel

GTK3-based panel for sway and Hyprland Wayland compositors
MIT License
629 stars 43 forks source link

Changing height and width causes crashing #283

Closed scrubborn closed 7 months ago

scrubborn commented 8 months ago

When changing window height and window width inside of the panel settings menu, upon saving and restarting I can see that nothing changed. If I check the config file for my preset, '/home/user/.config/nwg-panel/hyprland-2' then I can see under menu-start that the height and width are still set to 0, even after saving from the settings app. I tested padding and it didn't save either, it appears to be this whole menu-start category. Changing other panel settings appears to work, just not for this menu.

If I change the settings in the config file myself for height and width, the menu no longer opens.

scrubborn commented 8 months ago

Ok, updating yesterday didn't help but updating and restarting today changed this a bit. Now the panel settings appears to be saving properly, and changing the padding works now. The issue with the menu not loading once I change height and width however is still present.

nwg-piotr commented 8 months ago

This is a bug, but in nwg-panel, not in the menu. Transferring, will try and fix soon.

nwg-piotr commented 8 months ago

image

Alright, I know what's going on: "Window width" and "Window height" fields should not be in the form, as nwg-menu doesn't support neither -width nor -height argument. My mistake, sorry. I'll delete them at another nwg-panel update.

scrubborn commented 8 months ago

Gotcha, so in that case is there a way I can change the size? All the screenshots I've seen for the windows style menu look far larger, or atleast taller than mine.

nwg-piotr commented 8 months ago

The height depends on the content. The more items inside the menu, the taller it gets. If you only care about aesthetics, just pin up a few apps.

image

scrubborn commented 8 months ago

Cool, makes sense. Thanks for the help.

nwg-piotr commented 8 months ago

You're welcome. I hardly ever use nwg-menu myself, so it looks kind of abandoned. ;)

nwg-piotr commented 7 months ago

Nonexistent settings removed on Master.