search

nwg-piotr / nwg-panel

GTK3-based panel for sway and Hyprland Wayland compositors
MIT License
629 stars 43 forks source link

[BUG] RPM lint issue ambiguous python shebang #295

Closed tim77 closed 5 months ago

tim77 commented 5 months ago

Describe the bug In last v0.9.28 was added airplane-mode indicator script. It have minor issue which RPM linter consider as ERROR.

*** ERROR: ambiguous python shebang in /usr/lib/python3.12/site-packages/nwg_panel/executors/airplane_mode.py: #!/usr/bin/python. Change it to python3 (or python2) explicitly.

Expected behavior Satisfied linter.

Desktop (please complete the following information):

Additional context Some minor warnings also could be fixed/improved:

mangling shebang in /usr/lib/python3.12/site-packages/nwg_panel/executors/au.sh from /usr/bin/env bash to #!/usr/bin/bash
mangling shebang in /usr/lib/python3.12/site-packages/nwg_panel/executors/check-notifications from /bin/bash to #!/usr/bin/bash
mangling shebang in /usr/lib/python3.12/site-packages/nwg_panel/executors/github.sh from /bin/bash to #!/usr/bin/bash
*** WARNING: ./usr/share/applications/nwg-panel-config.desktop is executable but has no shebang, removing executable bit
tim77 commented 5 months ago

Thanks! New version built successfully without any build issue.

nwg-piotr commented 5 months ago

Great! Thanks for confirmation.