search

nwhitehead / pineapple

http://nwhitehead.github.io/pineapple/
Other
352 stars 26 forks source link

Add to homebrew #30

Open sammcj opened 9 years ago

sammcj commented 9 years ago

Would be great if pineapple could be added to @homebrew!

https://github.com/Homebrew/homebrew/tree/master/share/doc/homebrew#contributing

chrisidefix commented 9 years ago

I guess it should be added as a cask, which makes this a very simple exercise.

taylorterry3 commented 9 years ago

I'm going to do the below as a PR on caskroom/homebrew-cask today unless anyone objects. These are for the full versions. Homebrew discourages having things like separate full/min casks but people usually follow the Python convention of foo being the Py 2.* version and foo3 for 3.*. If anybody cares about having both full and min I'd suggest adding it to caskroom/homebrew-versions.

@nwhitehead LMK if you want to create a static "latest" s3 path instead of hard linking to the current 0.7.4. Thanks for the awesome tool!

cask :v1 => 'pineapple3' do
  version :0.7.4
  sha256 :no_check

  # amazonaws.com is the official download host per the vendor homepage
  url 'https://s3.amazonaws.com/com.nathansuniversity/Pineapple/Releases/Pineapple-Pro-0.7.4-Python3.5.dmg'
  name 'Pineapple'
  homepage 'http://nwhitehead.github.io/pineapple/'
  license :gpl

  app 'Pineapple-Pro.app'
end
cask :v1 => 'pineapple' do
  version :0.7.4
  sha256 :no_check

  # amazonaws.com is the official download host per the vendor homepage
  url 'https://s3.amazonaws.com/com.nathansuniversity/Pineapple/Releases/Pineapple-Pro-0.7.4-Python2.7.dmg'
  name 'Pineapple'
  homepage 'http://nwhitehead.github.io/pineapple/'
  license :gpl

  app 'Pineapple-Pro.app'
end
taylorterry3 commented 9 years ago

PR at https://github.com/caskroom/homebrew-cask/pull/13840

sammcj commented 9 years ago

Thanks @taylorterry3, it failed the tests due to two trailing blank lines, trivial I know.

taylorterry3 commented 9 years ago

Yeah, that was me failing at using my editor :)

Per the other comment on the PR, they'd like to make pineapple map to the python 3 version. I'm a python 3 guy so I support this, but it does kind of break convention. @nwhitehead what's your preference?

nwhitehead commented 9 years ago

@taylorterry3 I'm fine with "pineapple" being the 3.5 version.