nwhitehead / pineapple

http://nwhitehead.github.io/pineapple/
Other
351 stars 26 forks source link

update to jupyter notebook 5 #71

Open darthoctopus opened 7 years ago

darthoctopus commented 7 years ago

Jupyter notebooks 5 and ipython 6 introduce Jedi integration for ipython. With the codebase unmodified,

After fiddling around, I've found that the last issue stems from a change in either main.js or main.min.js in static/notebook/js. I'm not sure what is causing the broken callbacks.

darthoctopus commented 7 years ago

update: the broken callbacks were caused by the notebook_loaded.Notebook event in custom.js not being invoked on document load. As a workaround I've bound it to be triggered on command_mode. This is likely a Jupyter bug. Everything works beautifully otherwise.

gandalfsaxe commented 6 years ago

Is it updated yet? 😊