search

nwhitehead / pyfluidsynth

Python bindings for FluidSynth
GNU Lesser General Public License v2.1
197 stars 56 forks source link

Merge RamSoundFont, FileRenderer, gitignore and other goodies #27

Open ChristianRomberg opened 3 years ago

ChristianRomberg commented 3 years ago

Hi @pedromsilvapt. Seeing that you made some extensive and pretty nice looking additions to pyfluidsynth, I was wondering if you could merge them back into the base repository. Greetings, Chris

pedromsilvapt commented 3 years ago

Hi @ChristianRomberg, Sorry for the late reply. I'd be happy to merge them back, but to be honest I feel the code I did is a little bit of a mess right now, and some small parts are maybe too specific for the usecase I had. I was thinking of maybe creating a specific branch, where we could discuss what too include and what not, as well as allowing me to cleanup some stuff before merging. What do you think?

ChristianRomberg commented 3 years ago

Jeez I am so sorry. I did not mean to ghost this conversation. Of course, that sounds great.

pedromsilvapt commented 3 years ago

Don't worry, it's ok. I haven't had much time myself to work on it, but will try to do it soon.