nwhitehead / pyfluidsynth

Python bindings for FluidSynth
GNU Lesser General Public License v2.1
197 stars 56 forks source link

Add fluid_player_get_status and fix some typing bugs #44

Closed Fruchtzwerg94 closed 1 year ago

Fruchtzwerg94 commented 1 year ago

Fixed the data type for synth.sample rate according to the documentation to float. This removes the error: grafik

Also:

trenslow commented 1 year ago

@filipeborato any chance we can get these changes released in the near future?

filipeborato commented 1 year ago

@trenslow I don't have the power to merge, but I tested it and it looks ok.

trenslow commented 1 year ago

@filipeborato sorry, i naively assumed you had the power to merge since you approved the changes. how can we get the changes merged?

albedozero commented 1 year ago

Thanks! Sorry to take so long to get to this. I changed the title to reflect the adding of a new function binding, since this is a bigger change than bugfixes.

fixes https://github.com/nwhitehead/pyfluidsynth/issues/37

trenslow commented 1 year ago

Thanks a million @albedozero! I appreciate the work you guys are doing on this project.

TombCrawler commented 9 months ago

I've done all the change by [Fruchtzwerg94 but still got the same issue. Anyone?