nwhitehead / pyfluidsynth

Python bindings for FluidSynth
GNU Lesser General Public License v2.1
197 stars 56 forks source link

How to access reverb functionality #49

Closed brannanz closed 2 months ago

brannanz commented 6 months ago

This library is in dire need of some kind of api docs - how do I set the reverb level?? I tried set_reverb but no matter what arguments i gave it, it wouldn't work

nwhitehead commented 4 months ago

@brannanz Totally agree with everything you say. I had personally never tried reverb. I went through and wrote a test example for pull request #63. I managed to get it working.

One big thing I learned is that merely turning on reverb in fluidsynth is not enough to get reverb. You also have to have reverb send enabled in the SF2 file. Each preset in the SF2 can define how much signal to send to the reverb. In the example SF2 file there was (previously) no reverb set, so no matter what you do with fluidsynth reverb settings you would not hear reverb with the example SF2. I updated the SF2 to turn on reverb and got my new sample working. I used Polyphone to edit the sample SF2 file.

@brannanz Could you try the latest code in this repository and see if you can get reverb with test/test4.py?

brannanz commented 3 months ago

Will check later, thanks 😁

nwhitehead commented 2 months ago

Closing as inactive, feel free to re-open if you think there is still an issue.