search

nwidger / nintengo

An NES emulator written in Go
GNU General Public License v2.0
1.3k stars 51 forks source link

State Save/Load cleanup #17

Closed kaicheng closed 9 years ago

kaicheng commented 9 years ago

Now SaveState always save ROM data, so LoadStateEvent can restore the whole NES environment.

As we have to send a LoadStateEvent to slave any way, adding a separate logic to the event loop to setup state in slave looks redundant in this version.

Any comments?

nwidger commented 9 years ago

I like what I see. Although perhaps NewROMFromRaw can be removed and we'll just have that code in NewROM since we don't need to separate them out anymore?

kaicheng commented 9 years ago

Yes, thanks for point it out. I forgot to cleanup this function...

On Wed, Feb 4, 2015 at 5:58 PM, Niels Widger notifications@github.com wrote:

I like what I see. Although perhaps NewROMFromRaw can be removed and we'll just have that code in NewROM since we don't need to separate them out anymore?

— Reply to this email directly or view it on GitHub https://github.com/nwidger/nintengo/pull/17#issuecomment-72967007.

Kaicheng Zhang (Chinese Name: 张凯程)

kaicheng commented 9 years ago

pump