nwihardjo / Java-Webscrapper

Amazon and craigslist multi-threads webscraper

https://nwihardjo.github.io/Java-Webscrapper/

2 stars 2 forks source link

Number format exception when scraping #7

Closed hanifdean closed 5 years ago

hanifdean commented 5 years ago

Can you take a look at this? I think there's a bug with dealing with a different number format (i.e. 2,300 as compared to 2300)

hanifdean commented 5 years ago

uptoyou #lol

hanifdean commented 5 years ago

^ iseng lol

nwihardjo commented 5 years ago

is this bug caused by https://github.com/nwihardjo/Java-Webscrapper/commit/ee2a0a380742b48d8be38154796ec4466667fc8e ?

hanifdean commented 5 years ago

I don't think so, but it happens on some items only. It happened when I searched "watch", but it didn't happen when I searched stuff like iPhone. Probably happened on more luxurious items because the prices were higher so it had "," to separate the price (i.e. 2,999).

nwihardjo commented 5 years ago

Yep, it should be fixed by https://github.com/nwihardjo/Java-Webscrapper/commit/ee2a0a380742b48d8be38154796ec4466667fc8e Try merging with the most recent commit in master, lmk if the problem still persists.

hanifdean commented 5 years ago

thanks yo