search

nwithan8 / plex-prerolls

Schedule Plex Pre-Roll listings
GNU General Public License v3.0
30 stars 0 forks source link

[Feature] Pointing to folders instead of files #1

Closed costaht closed 5 months ago

costaht commented 5 months ago

First of all, thanks for keep this project going.

I'd like to suggest a change where we'd point to a folder instead of files. That will allow the user to just drop files into a folder, let's say "Christmas" and plex-prerolls will automatically pick them up. That also is gonna make the config file cleaner

Folder structure example:

pre-rolls/
├── christmas
├── easter
├── fall
├── halloween
└── independence

Thanks

nwithan8 commented 5 months ago

Unfortunately, Plex doesn't work that way. The preroll list on Plex needs to be full file paths, not just folders: https://support.plex.tv/articles/202920803-extras/#:~:text=To%20specify%20a%20pre%2Droll%20video%2C%20simply%20enter%20the%20full%20path%20to%20the%20file%20(e.g.%20/Users/sarah/Movies/preroll.mp4

Thanks for the suggestion though!

raph521 commented 5 months ago

Apologies if you do not prefer commenting on closed issues, I wasn't sure if it was worth creating a new one of this same feature request.

As a solution to Plex's requirement that full file paths be specified instead of directory paths, could the script glob/ls the the files in a configured directory and build full file paths with that list, to then be configured as pre-rolls?

For containers, that would just also require that the prerolls directories be mounted with the same directory structure as Plex.

costaht commented 5 months ago

@raph51 that's exactly what my proposal was. List the files and concatenate all the paths

nwithan8 commented 5 months ago

For containers, that would just also require that the prerolls directories be mounted with the same directory structure as Plex.

The original proposal is a good one and I considered it, but this ^ popped up as an immediate roadblock. For me personally, I run this container on a completely different system from my Plex server, so there would be no way to pass in the Plex folder path to the system.

I'll see if I can spec something up as perhaps a toggle-able feature.

costaht commented 5 months ago

I run this container on a completely different system from my Plex server

But I think you're an exception haha. I run everything on the same machine and believe most people do, unless those who have a big number of users and need dedicated hardware.

nwithan8 commented 5 months ago

Feel free to weigh in on #3 @costaht @raph521 . I'll cut a release soon. Please note, while it worked in initial testing for me, this is considered beta!

ThatTallGuy21 commented 1 month ago

@costaht @raph521 -- Is this working for you? I posted the below error and I'm having issues with one or more defined paths. Below is the issue I've opened.

https://github.com/nwithan8/plex-prerolls/issues/4