search

nwixsom / gwt-cal

Automatically exported from code.google.com/p/gwt-cal
0 stars 0 forks source link

Enhancement Request - Use generic List's in the API's #158

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Rather than dictating the List implementation required for things, would it be 
possible to use List's of objects instead ArrayList's in the gwt-cal APIs?  Is 
there some reason in the code that it requires an ArrayList vs. a List?

E.g., Calendar.addAppointments(..) takes as a paramter an 
ArrayList<Appointment>.  I'd like to see this changed to List<Appointment> 
instead.  Let me decide the list implementation I want to use to back my list 
of appointments.  There are other examples of this as well.

Original issue reported on code.google.com by drfoste...@gmail.com on 7 Jun 2012 at 5:41

GoogleCodeExporter commented 9 years ago 
From a puristic API designer point of view I think you're right. In fact that's 
something that should be fixed/changed before the 1.0 release.

The best approach is probably to deprecate the current methods and remove them 
after 2 or 3 releases.

Original comment by ctasada on 11 Jun 2012 at 9:00

GoogleCodeExporter commented 9 years ago 
agreed Carlos ... I believe the reason we didn't use generics, initially, was 
that back when I created the project GWT's serializer did not yet handle 
generics.

Original comment by Brad.Ryd...@gmail.com on 11 Jun 2012 at 9:03

GoogleCodeExporter commented 9 years ago 
Due to the polymorphic nature of the change the deprecation is finally not 
needed. Please take a look to r415 for the changes

Original comment by ctasada on 13 Jun 2012 at 8:58

GoogleCodeExporter commented 9 years ago 
Who is this PendingReview on?  Me?  Brad?

Original comment by drfoste...@gmail.com on 14 Jun 2012 at 3:29

GoogleCodeExporter commented 9 years ago 
Mainly on Brad, but if you find anything wrong don't hesitate to say it ;)

Original comment by ctasada on 14 Jun 2012 at 7:47

GoogleCodeExporter commented 9 years ago

Original comment by ctasada on 23 Jan 2013 at 11:20