nwixsom / gwt-cal

Automatically exported from code.google.com/p/gwt-cal
0 stars 0 forks source link

Bug in DayView with rev 287 #43

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi Brad,

Here's the issue as we talked on emails:

I'm working with the 0.9 branch and syncing with your changes in the
repository. I've seen that at some point (I think between rev 270 and
287) the DayView is not drawn properly.

If you scroll up to the beginning of the day, appears an empty
interval, and another empty interval appears if you scroll down to the
end of the day.

Attached you can find 2 screenshots.

I've done my tests with the next combinations:
Windows XP SP3 - Firefox 3.6.2 & Google Chrome 5.0.342.8
Ubuntu 9.10 - Firefox 3.6.2

So doesn't seem to be related with the OS.

Please, tell me if I can help you with something. Anyway I'll try to debug
it this week.

Best Regards,
Carlos.

Original issue reported on code.google.com by ctasada on 30 Mar 2010 at 10:07

Attachments:

GoogleCodeExporter commented 9 years ago
Ahh, i think this is an easy one to fix. Do you have 
CalendarSettings.setOffsetHourLabels(true); ??

This should only ever be set to true if you are using the iCal theme, for 
formatting 
purposes 

Original comment by Brad.Ryd...@gmail.com on 30 Mar 2010 at 10:39

GoogleCodeExporter commented 9 years ago
Hi Brad,

You're right. I feel quite stupid. The "problem" was that rev 276 the 
gwt-cal-demo is
using the iCalCalendarPanel by default, which uses the setOffsetHourLabels(true)

Mystery solved. The case can be closed :)

Original comment by ctasada on 31 Mar 2010 at 7:46

GoogleCodeExporter commented 9 years ago
Closing this issue... but we really should remove OffsetHourLabels all-together 
and 
use the themes/deferred binding to automatically offset the timeline based on 
the 
user-selected theme. 

Original comment by Brad.Ryd...@gmail.com on 1 Apr 2010 at 9:41