search

nwjs / nw-gyp

native addon build tool for node-webkit
MIT License
195 stars 50 forks source link

Node gyp 3 update #108

Closed ghostoy closed 7 years ago

ghostoy commented 7 years ago

Merge with node-gyp 3.6.2 to support VS 2017.

rogerwang commented 7 years ago

Thanks. Would you just place our commits on top of upstream in your branch (just like what we did with the Chromium and v8 repo)? Then I'll just push it rather than using github PR.

ghostoy commented 7 years ago

@rogerwang The new branch is now in node-gyp-3.6.2 branch.

rogerwang commented 7 years ago

@ghostoy do I need to push it to npm or you'll do it?

ghostoy commented 7 years ago

@rogerwang Yes, please help. I don't have account of npm for publishing nw-gyp.

rogerwang commented 6 years ago

@ghostoy I just pushed it. And what's your npmjs.org account? I'll add you to the collaborators list.