search

nwjs / nw-gyp

native addon build tool for node-webkit
MIT License
195 stars 46 forks source link

Update nw-gyp to latest node-gyp 6.1.0 #136

Open surunzi opened 4 years ago

surunzi commented 4 years ago

Manually tested a few native modules in both windows 7 and macOS Mojave with nw 0.44, looks ok.

KittenHero commented 4 years ago

I hope this gets merged

gpetrov commented 4 years ago

@rogerwang - could you check if this is all good? It will be really nice to be up to the latest node-gyp

rogerwang commented 4 years ago

Thanks for the PR, but please rebase the nw-gyp patches to the new upstream version, rather than merging them into one commit.